move session and fetching to the feed manager
Having the session and the network code in the "model" makes no sense: that stuff belongs in the "controller". Having it there made it particularly difficult to implement the caching layer, as I had...
View Articleremove class-level sticky session parameter
This cleans up a lot of stuff. Now we can treat the session as a normal feed_manager parameter. Since there is usually only one feed_manager in operation at any time, it is basically a static member....
View Articlemake test suite pass again
This was failing because hooking up the cache into the session completely obliterates our poor old betamax cache. Instead of doing that, we politely queue the cache layer behind it... ... except that...
View Articlerename feeds to feed_manager in main
The "feeds" appelation is an old remnant of the previous data structures. Now we do use a FeedManager everywhere and we should name it as such. It will be easier to grep for it and will more obviously...
View Articlereuse feed_manager object in fetch as well
I see no reason why we need to construct a different object in this specific class, let's just reuse the one already created. This should make a tiny improvement on the startup latency, but hasn't...
View ArticleDRY: refactor common requirements out of tox and setup.py
Requirements are now stored only in setup.py. Before, we were telling tox to delegate the test runs to setup.py, but this made it impossible to pass arguments to pytest. By calling pytest directly, we...
View Articleexplicitely override the feed, not the session
This gives us a single override point that is more cohesive and cleaner. It will also make other run tests much easier to call, but that's for a later commit.
View Articleremove useless --config and --database and override instead
By passing the feed_manager, we have complete and coherent control over those parameters, without having to pass along the arguments. The downside is we create empty cassettes for all of those, but...
View Articleadd empty test cassettes artifacts
Those seem to be created now that we use the betamax session everywhere, but they are probably harmless.
View Article
